Fixes bug where applying the Torch interface repeatedly after expansion caused an error #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh146
commented
Apr 16, 2021
josh146
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 145 145
Lines 10985 10986 +1
=======================================
+ Hits 10779 10780 +1
Misses 206 206
Continue to review full report at Codecov.
|
trbromley
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Thanks @josh146! We can revert PennyLaneAI/qml#247 once this is merged in 🎉
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Applying the Torch interface, twice, to an expanded tape, resulted in an error. This is because the
expand()function was not retaining the__bare__attribute of the tape, which stores the original (pre-interface) class of the tape.Description of the Change: The
expand()method now retains the__bare__attribute. A test has also been added.Benefits: Fixes the aforementioned bug.
Possible Drawbacks: Not a drawback per se, just a note: once we remove tape subclasses (alongside gradient methods becoming transforms), we can remove the
__bare__attribute.Related GitHub Issues: Closes #1210