Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #1250

Closed
wants to merge 1 commit into from
Closed

Update CHANGELOG.md #1250

wants to merge 1 commit into from

Conversation

ryanhill1
Copy link
Contributor

Added new entry to the .github/CHANGELOG.md file, summarizing PR (#1249).

@josh146
Copy link
Member

josh146 commented Apr 22, 2021

Hey @ryanhill1! It's best to make the commit that updates the changelog in the same PR as the one that adds the changes (so #1249). So feel free to push this particular change directly in the existing branch for that addition 🙂

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #1250 (d8d84be) into master (35ab137) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1250   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         146      146           
  Lines       11035    11035           
=======================================
  Hits        10830    10830           
  Misses        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35ab137...d8d84be. Read the comment docs.

@ryanhill1
Copy link
Contributor Author

@josh146 oops sorry! I'll do that now.

@ryanhill1 ryanhill1 closed this Apr 22, 2021
@ryanhill1 ryanhill1 deleted the patch-2 branch April 22, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants