Fix issue #1266: 'convert_observable' function raises an error for QubitOperators containing complex coefficients #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agran2018
added
review-ready 👌
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 147 147
Lines 11277 11279 +2
=======================================
+ Hits 11067 11069 +2
Misses 210 210
Continue to review full report at Codecov.
|
agran2018
commented
May 5, 2021
| qml.Identity(wires=[0]) @ qml.Identity(wires=[1]), | ||
| qml.Identity(wires=[0]) @ qml.PauliZ(wires=[1]), | ||
| qml.PauliZ(wires=[0]) @ qml.Identity(wires=[1]), | ||
| ] | ||
|
|
There was a problem hiding this comment.
Changes from this point on seem to be related to "black"
zeyueN
approved these changes
May 5, 2021
Co-authored-by: zeyueN <48225584+zeyueN@users.noreply.github.com>
|
@agran2018 Thanks so much for fixing this! Would be great if we could merge today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR address the issue #1266. Now, an error message is raised if a QubitOperator containing complex coefficients is passed
to the
convert_observablefunction. Currently, thevqe.Hamiltonianclass does not support complex coefficients.Description of the Change:
The
convert_observablechecks that all coefficients in the QubitOperator are real.