Finalize max-weight-cycle qaoa addition #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trbromley
commented
May 11, 2021
•
trbromley
commented
- update docs
- update changelog
Codecov Report
@@ Coverage Diff @@
## master #1297 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 147 147
Lines 11352 11352
=======================================
Hits 11142 11142
Misses 210 210 Continue to review full report at Codecov.
|
trbromley
changed the title
trbromley
added
the
review-ready 👌
anthayes92
approved these changes
May 12, 2021
| :no-heading: | ||
| :no-inheritance-diagram: | ||
| :no-inherited-members: | ||
| The :mod:`~.cycle` module is available for additional functionality related to the maximum-weighted |
There was a problem hiding this comment.
Looks good! The only question I have is whether cycle_mixer() belongs in qaoa.cycle.py or qaoa.mixers.py?
It's currently in qaoa.cycle.py which means it doesn't appear under "Mixer Hamiltonians" in the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.