-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unitaryHACK] Add reset error to noise channels #1321
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
123ddda
add ResetError channel
nahumsa 87c419d
updated test parameters
nahumsa 88e9375
updated docs
nahumsa 3ccbbac
add entry to changelog
nahumsa bb468e8
Merge branch 'master' into add-reset-error
josh146 44ae9cd
run black
nahumsa 891e3c8
Merge branch 'add-reset-error' of https://github.com/nahumsa/pennylan…
nahumsa 53b6986
fix docs
nahumsa c0a1256
fix tests
nahumsa b1e01de
fix name of tests
nahumsa b1bc4f5
Merge branch 'master' into add-reset-error
josh146 85b7bb5
Update changelog
nahumsa c384377
add name to contributors
nahumsa f020b48
add grad recipe for `p_1`
nahumsa 7e66d67
Merge branch 'master' into add-reset-error
antalszava 31d91e1
change `grad_method` to "F"
nahumsa af53e0d
add `ResetError` when testing if it is trace preserving
nahumsa 4ce0c52
remove analytic gradient test for `ResetError`
nahumsa 2783fc5
Merge branch 'master' into add-reset-error
josh146 05c5f38
Merge branch 'master' into add-reset-error
josh146 61ed7d8
updated kraus operators
nahumsa 2623fd3
Merge branch 'add-reset-error' of https://github.com/nahumsa/pennylan…
nahumsa e8d16b1
fix channel names
nahumsa 77ab397
fix test channel names
nahumsa b35a7be
Merge branch 'master' into add-reset-error
nahumsa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nahumsa Why did you change the definition of the channel?
Before approving, could you please point me to a reference where this channel is defined? I would like to make sure that the name "reset error" coincides with the standard usage. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ixfoduap ! I was reading through the qiskit's docs and found a direct reference about the
![image](https://user-images.githubusercontent.com/49600259/118862685-63a03580-b8b4-11eb-9e16-e3532cb864ac.png)
ResetError
Kraus operators:This was the main reason that I changed the definition of the channel, do you think that this is reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks for the clarification!