-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unitaryHACK] Added SWAP gate decomposition and related tests #1329
[unitaryHACK] Added SWAP gate decomposition and related tests #1329
Conversation
Co-authored-by: antalszava <antalszava@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1329 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 148 148
Lines 11446 11450 +4
=======================================
+ Hits 11236 11240 +4
Misses 210 210
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @charmerDark, this looks good to me! 🎉 🙂 Extra credit for going through the challenges with git
. Thank you for your contribution! :)
Thank you so much @antalszava Couldn't have made it without all your support. I learnt so much from this. Hope to be able to contribute more to pennylane soon. |
Context:
Added SWAP decomposition and wrote tests to it
Description of the Change:
added the the function
to
pennylane/ops/qubit.py
and tests for it attests/ops/test_qubit_ops.py
Possible Drawbacks:
similar to #1313
Related GitHub Issues:
resolves #1304