Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated benchmark module #1343

Merged
merged 7 commits into from
May 25, 2021
Merged

Conversation

mariaschuld
Copy link
Contributor

Context:

The benchmark folder in PennyLane contained some outdated benchmarks, which have in the meantime been superseded by a separate repository.

Description of the Change:

  • Delete folder
  • Update changelog

I could not find any references to the folder in docs/workflows, so I hope nothing else needs to be done.

Benefits:

Code quality.

@mariaschuld mariaschuld requested a review from josh146 May 20, 2021 06:45
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #1343 (7043015) into master (b04b5ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         150      150           
  Lines       11256    11256           
=======================================
  Hits        11062    11062           
  Misses        194      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04b5ac...7043015. Read the comment docs.

@mariaschuld mariaschuld merged commit 499e5eb into master May 25, 2021
@mariaschuld mariaschuld deleted the remove-benchmark-folder branch May 25, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants