Fix drawing a QNode with no operations #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antalszava
commented
May 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 146 146
Lines 11150 11150
=======================================
Hits 10956 10956
Misses 194 194
Continue to review full report at Codecov.
|
josh146
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
QNodes with no operations raises an error when drawn.
This error boils down to the grid that the
CircuitDrawercreates. There is a copying operation that is called on aNonetype object (due to having no operations).Changes
Catches the case where the grid is
Noneand no copying of the internal grid happens, instead, an empty grid is used.Ralated Issues
#1326