Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equation typo in qaoa.cycle loss Hamiltonian docstring #1396

Merged
merged 6 commits into from
Jun 10, 2021

Conversation

anthayes92
Copy link
Contributor

As titled.

@anthayes92 anthayes92 requested a review from trbromley June 9, 2021 17:11
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2021

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anthayes92! Still worth updating the changelog, the documentation section has similar entries for typos.

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #1396 (4d2fb9a) into master (92c0ae7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1396   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         157      157           
  Lines       11729    11729           
=======================================
  Hits        11517    11517           
  Misses        212      212           
Impacted Files Coverage Δ
pennylane/qaoa/cycle.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c0ae7...4d2fb9a. Read the comment docs.

@anthayes92
Copy link
Contributor Author

@trbromley my editor has auto-formatted the changelog again. Thought it's worth mentioning. If it looks ok to you I'll merge this in.

@anthayes92 anthayes92 requested a review from trbromley June 9, 2021 17:44
.github/CHANGELOG.md Outdated Show resolved Hide resolved
.github/CHANGELOG.md Outdated Show resolved Hide resolved
anthayes92 and others added 2 commits June 10, 2021 11:44
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
@anthayes92 anthayes92 merged commit d320f59 into master Jun 10, 2021
@anthayes92 anthayes92 deleted the fix_qaoa_cycle_loss_hamiltonian_docstring branch June 10, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants