IsingYY differentiability
#1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmoyard
changed the title
IsingYY differentiability
Codecov Report
@@ Coverage Diff @@
## master #1425 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 160 160
Lines 12016 12027 +11
=======================================
+ Hits 11805 11816 +11
Misses 211 211
Continue to review full report at Codecov.
|
rmoyard
added
review-ready 👌
|
@rmoyard is this review ready? Just checking, as no-one has been tagged for review :) |
|
@josh146 Yes indeed it is ready! I forgot to tag someone. |
josh146
approved these changes
Jun 29, 2021
| @@ -1849,6 +1849,7 @@ class IsingYY(Operation): | |||
| num_wires = 2 | |||
| par_domain = "R" | |||
| grad_method = "A" | |||
| generator = [np.array([[0, 0, 0, -1], [0, 0, 1, 0], [0, 1, 0, 0], [-1, 0, 0, 0]]), -1 / 2] | |||
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
|
Hi @rmoyard, is this PR ready to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR makes
IsingYYdifferentiable for the different devices Jax, TensorFlow and Autograd.Description of the Change:
IsingYYoperation tojax_ops.py,autograd_ops.py, andtf_ops.py.DefaultQubitAutograd,DefaultQubitJAX, andDefaultQubitTFdevices to supportIsingYY.diff-method.Related Issues
Closes #1347