Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The existing parameter-shift Hessian implementation returns incorrect Hessians for cost functions that perform post-processing on a vector-valued QNode.
Description of the Change:
The bug was fixed in all three main interfaces (autograd, PyTorch, TF), by making sure that the vector-Hessian product is divided by the norm squared of
dy
.Tests were added for all three interfaces to ensure that this bug is fixed.
Benefits: Fixes the aforementioned bug.
Possible Drawbacks: n/a
Related GitHub Issues: Fixes #1424