-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qml.layer
support for tensorflow Variable
#1615
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1615 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 196 196
Lines 14158 14159 +1
=======================================
+ Hits 14036 14037 +1
Misses 122 122
Continue to review full report at Codecov.
|
…ylane into bugfix-layer-tf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @albi3ro , it looks good to me 👍 Just a small comment to add for the test.
Co-authored-by: Romain <rmoyard@gmail.com>
Fixes #1611
qml.layer
usedlen
to validate the length of the input argument, but tensorflowtf.Variable
objects do not support calculation oflen
. Instead we useqml.math.shape(arg)[0]
to allow the template to support all interfaces.