Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relevant tests skip if cvxpy or dask is not installed #1617

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Sep 1, 2021

Fixes #1593

Currently, the tests folder does not pass cleanly if only pennylane and required dependencies are installed, as dask and cvxpy are not required dependencies. This PR skips tests that require one of these modules, but the module is not installed.

I am still investigating the device suite tests, but those will be a separate PR.

@albi3ro albi3ro requested a review from thisac September 1, 2021 12:08
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1617 (99d1bff) into master (51c1b76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1617   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files         196      196           
  Lines       14162    14162           
=======================================
  Hits        14040    14040           
  Misses        122      122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c1b76...99d1bff. Read the comment docs.

@albi3ro albi3ro added bug 🐛 Something isn't working review-ready 👌 PRs which are ready for review by someone from the core team. labels Sep 1, 2021
@rmoyard rmoyard self-requested a review September 1, 2021 14:22
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @albi3ro, it is great to have those fixtures 👍



@pytest.fixture(scope="session")
def dask_support():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 💯

@albi3ro albi3ro merged commit 20ae884 into master Sep 1, 2021
@albi3ro albi3ro deleted the test-versions branch September 1, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working review-ready 👌 PRs which are ready for review by someone from the core team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Failing tests due to DASK and CVXPY Modules
2 participants