-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark tests slower than 1.5 seconds #1633
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #1633 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 196 196
Lines 14241 14241
=======================================
Hits 14119 14119
Misses 122 122 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, I didn't know we could mark the tests 👍 I've tested it and it works well on my side. Just a small comment for the changelog. 💯
@@ -0,0 +1,3 @@ | |||
[pytest] | |||
markers = | |||
slow: marks tests as slow (deselect with '-m "not slow"') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! 💯
Co-authored-by: Romain <rmoyard@gmail.com>
This PR marks the 35 or so slowest tests that took longer than 1.5 seconds on my computer as "slow".
You can locally run all not slow tests via the command:
This will hopefully make the local execution of the test suite easier.
I also added the
pytest.ini
file to register the"slow"
mark.In the future, slow tests that get added should be marked via
@pytest.mark.slow
.