Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.18.0 release notes #1656
V0.18.0 release notes #1656
Changes from 6 commits
36ddeb1
15bd218
7d8bd57
4735988
c06e82e
8177644
f0a0b42
e6317d8
8721f7b
3e577d7
8e45751
015c565
45b39ba
057d135
72c09e8
57c533b
e8578ca
26a92ca
f36c39e
9020602
208272d
9e1975e
4ba2ef1
83488d6
9de740a
b149de4
9ef129d
de6f2c2
d3eff25
cd87c7d
8a6c761
46cae89
7c98c9a
71a4fd4
0bc6db0
140ece6
6f2c00b
6080ef4
12291ba
8edd7aa
c3d2236
2b5ffa6
90cc245
9b8d354
2ca8fa1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels weird to have this as a separate category with only a single new operation 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. It doesn't really fit any of the other categories, so I've added it into Improvements. An alternative to that would be creating a general catch-all category that we can use for each release: e.g.,
"Further new features"
or so.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this one I would probably move to the 'Faster Hamiltonian' section of 'New Features'. I wonder if @soranjh has any benchmark plots we could include in order to show-off the speed improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have some data. Please let me prepare a clean figure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it look? Please let me know if any correction needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome @soranjh 💪
Only suggestion is minor - might be good to modify the title to say
to avoid readers thinking this speedup occurs for hardware devices/finite-shots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(edited the font size)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the latest plot in fa6df8f as part of #1671.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A massive contributor list 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that Jay is missing from this list, I recall him doing code review for bugs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Thanks for that.