-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename qml.Interferometer
to qml.InterferometerUnitary
#1714
Rename qml.Interferometer
to qml.InterferometerUnitary
#1714
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1714 +/- ##
==========================================
- Coverage 99.21% 99.21% -0.01%
==========================================
Files 204 204
Lines 15429 15425 -4
==========================================
- Hits 15308 15304 -4
Misses 121 121
Continue to review full report at Codecov.
|
Hi @antalszava ! Can I implement this change too?
|
I am not sure why
|
qml.Interferometer
to qml.InterferometerUnitary
qml.Interferometer
to qml.InterferometerUnitary
Hey @AkashNarayanan, I will check your PR as soon as possible. Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AkashNarayanan, thank you for the great contribution! It looks good to me but I don't know why the coverage is failing. I'll come back to you later.
Yes for sure you can go for it, it should be straightforward! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, @josh146 you can bypass codecov and merge it 💯
Context:
This PR renames
qml.Interferometer
toqml.InterferometerUnitary
in order to distinguish it fromqml.templates.Interferometer
.Description of the Change:
qml.Interferometer
toqml.InterferometerUnitary
and updated references to it throughout the code base.Rendered Documentation Page:
qml.InterferometerUnitary
Benefits:
qml.templates.Interferometer
can now be turned into an operation since the name conflict has been resolved.Related GitHub Issues:
#1709