Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename qml.Interferometer to qml.InterferometerUnitary #1714

Merged
merged 10 commits into from
Oct 8, 2021

Conversation

AkashNarayanan
Copy link
Contributor

@AkashNarayanan AkashNarayanan commented Oct 2, 2021

Context:
This PR renames qml.Interferometer to qml.InterferometerUnitary in order to distinguish it from qml.templates.Interferometer.

Description of the Change:

  • Renamed qml.Interferometer to qml.InterferometerUnitary and updated references to it throughout the code base.
  • Removed the deprecation warning regarding the renaming of the operation.
  • Updated the test cases.

Rendered Documentation Page:
qml.InterferometerUnitary

Benefits:

  • Improves the distinction between the operation and the template.
  • qml.templates.Interferometer can now be turned into an operation since the name conflict has been resolved.

Related GitHub Issues:
#1709

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #1714 (51454f3) into master (05b1987) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1714      +/-   ##
==========================================
- Coverage   99.21%   99.21%   -0.01%     
==========================================
  Files         204      204              
  Lines       15429    15425       -4     
==========================================
- Hits        15308    15304       -4     
  Misses        121      121              
Impacted Files Coverage Δ
...ennylane/circuit_drawer/representation_resolver.py 99.36% <ø> (ø)
pennylane/devices/default_gaussian.py 99.64% <100.00%> (ø)
pennylane/ops/cv.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b1987...51454f3. Read the comment docs.

@AkashNarayanan
Copy link
Contributor Author

Hi @antalszava ! Can I implement this change too?

In addition to the PennyLane code base, the change should also be implemented with a separate PR in the StrawberryFields plugin that is not part of this repo, but in here.

@AkashNarayanan
Copy link
Contributor Author

I am not sure why codecov/project is failing. It states here as follows

Everything is accounted for!
No changes detected that need to be reviewed.

@AkashNarayanan AkashNarayanan changed the title Renamed qml.Interferometer to qml.InterferometerUnitary Rename qml.Interferometer to qml.InterferometerUnitary Oct 4, 2021
@rmoyard
Copy link
Contributor

rmoyard commented Oct 4, 2021

Hey @AkashNarayanan, I will check your PR as soon as possible. Thank you for your contribution!

@rmoyard rmoyard self-requested a review October 4, 2021 21:09
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AkashNarayanan, thank you for the great contribution! It looks good to me but I don't know why the coverage is failing. I'll come back to you later.

@rmoyard
Copy link
Contributor

rmoyard commented Oct 6, 2021

Hi @antalszava ! Can I implement this change too?

In addition to the PennyLane code base, the change should also be implemented with a separate PR in the StrawberryFields plugin that is not part of this repo, but in here.

Yes for sure you can go for it, it should be straightforward!

@rmoyard rmoyard self-requested a review October 7, 2021 18:56
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, @josh146 you can bypass codecov and merge it 💯

@josh146 josh146 merged commit 949f5d5 into PennyLaneAI:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants