Collect expand_fns and stopping criteria into central file
#1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnylane into restructure-metric_tensor
…nnylane into restructure-metric_tensor
Co-authored-by: Josh Izaac <josh146@gmail.com>
…nnylane into restructure-metric_tensor
josh146
requested changes
Oct 13, 2021
There was a problem hiding this comment.
@dwierichs 🎉 The new naming and structure now feels 💯!
All my comments and suggestions are minor, and mainly wrt documentation 🙂
Co-authored-by: Josh Izaac <josh146@gmail.com>
… into collect-expand_fns
… into collect-expand_fns
|
Hi @josh146 I think everything should be addressed now :)
|
josh146
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
This is such a nice addition @dwierichs 😍
Happy to approve, conditional on my suggestions below. Don't forget to add the tape_expand functions to the transforms/__init__.py module docstring, and check that they render correctly in the PR documentation build!
Comment on lines
+1927
to
+1930
| @qml.BooleanFn | ||
| def is_measurement(obj): | ||
| """Returns ``True`` if an operator is a ``MeasurementProcess`` instance.""" | ||
| return isinstance(obj, qml.measure.MeasurementProcess) |
There was a problem hiding this comment.
docstring renders nicely!
There was a problem hiding this comment.
Very nice that you caught this one! :)
Co-authored-by: Josh Izaac <josh146@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
tape expansion functions are scattered across PL, this PR collects them, introducing a handy wrapping class that enables logical conjunction of callables.
Description of the Change:
Introduce
StoppingCriterion, a new wrapper class, as well as a convenience functionget_expand_fnto create anexpand_fnfrom a stopping criterion.Benefits:
Centralized expansion functions and convenient composition of stopping criteria.
Possible Drawbacks:
Likely a bit less performant that explicitly writing out the logical functions locally in the corresponding files.
Related GitHub Issues:
#1732