Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jax interface missing from QNode documentation #1729 #1755

Merged
merged 9 commits into from
Oct 15, 2021
Merged

jax interface missing from QNode documentation #1729 #1755

merged 9 commits into from
Oct 15, 2021

Conversation

anonymousr007
Copy link
Contributor

@anonymousr007 anonymousr007 commented Oct 14, 2021

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1755 (5e4f00c) into master (a765663) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1755   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         207      207           
  Lines       15587    15587           
=======================================
  Hits        15466    15466           
  Misses        121      121           
Impacted Files Coverage Δ
pennylane/qnode.py 98.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a765663...5e4f00c. Read the comment docs.

pennylane/qnode.py Outdated Show resolved Hide resolved
@anonymousr007 anonymousr007 changed the title jax interface missing from QNode documentation #1729 [hacktoberfest] jax interface missing from QNode documentation #1729 Oct 15, 2021
@anonymousr007 anonymousr007 changed the title [hacktoberfest] jax interface missing from QNode documentation #1729 jax interface missing from QNode documentation #1729 Oct 15, 2021
@anonymousr007
Copy link
Contributor Author

All checks have passed

@Jaybsoni
Copy link
Contributor

All checks have passed
Hey @anonymousr007,

Even though the checks pass, the formatting is not quite correct, we do want an empty between the autograd point and the jax point. I think the reason the checks didn't pass last time was because the empty line was tabbed, so there was some additional white space there that shouldn't have been there.

Thanks

@anonymousr007
Copy link
Contributor Author

It's done 😄

@Jaybsoni
Copy link
Contributor

Awesome!
Thanks @anonymousr007 for the contribution! Feel free to contribute to other open issues. This is ready to be merged in!

@Jaybsoni Jaybsoni self-requested a review October 15, 2021 18:07
@anonymousr007
Copy link
Contributor Author

How much time does it take to merged?

@Jaybsoni
Copy link
Contributor

Ah there is one more thing that needs to be done. Please add your change along with your name to the change-log (which can be found here). If you scroll down to the bottom of the file, there should be section called documentation, add a bullet point briefly describing your change and link your PR. Then add your name to the list of contributors (in alphabetical order)!

Thanks again! :)

@Jaybsoni
Copy link
Contributor

How much time does it take to merged?

Once you update the change log as I have described above and push. I can approve it on our end and have it merged in :)

@Jaybsoni Jaybsoni merged commit 962f695 into PennyLaneAI:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants