-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jax interface missing from QNode documentation #1729 #1755
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1755 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 207 207
Lines 15587 15587
=======================================
Hits 15466 15466
Misses 121 121
Continue to review full report at Codecov.
|
All checks have passed |
Even though the checks pass, the formatting is not quite correct, we do want an empty between the autograd point and the jax point. I think the reason the checks didn't pass last time was because the empty line was tabbed, so there was some additional white space there that shouldn't have been there. Thanks |
It's done 😄 |
Awesome! |
How much time does it take to merged? |
Ah there is one more thing that needs to be done. Please add your change along with your name to the change-log (which can be found here). If you scroll down to the bottom of the file, there should be section called documentation, add a bullet point briefly describing your change and link your PR. Then add your name to the list of contributors (in alphabetical order)! Thanks again! :) |
Once you update the change log as I have described above and push. I can approve it on our end and have it merged in :) |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint
, and thenrun
pylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: