Remove the pad argument from amplitude embedding template

[Jaybsoni]

Deprecating the pad argument in AmplitudeEmbedding for the next release.

[github-actions]

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

• A one-to-two sentence description of the change. You may include a small working example for new features.
• A link back to this PR.
• Your name (or GitHub username) in the contributors section.

[codecov]

Codecov Report

Merging #1805 (90e9ceb) into master (c81a038) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1805      +/-   ##
==========================================
- Coverage   98.92%   98.92%   -0.01%     
==========================================
  Files         209      209              
  Lines       15733    15727       -6     
==========================================
- Hits        15564    15558       -6     
  Misses        169      169              

Impacted Files	Coverage Δ
pennylane/transforms/qfunc_transforms.py	100.00% <ø> (ø)
pennylane/templates/embeddings/amplitude.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81a038...90e9ceb. Read the comment docs.

[antalszava]

Hi @Jaybsoni, just a fly-by comment: don't forget to add an item to the Breaking Changes section about this. 🙂 (Users who've used pad before will have their codes break.)

Also, at a first glance, it will likely break tutorial_multiclass_classification.py in the QML repo.

[Jaybsoni]

Hi @Jaybsoni, just a fly-by comment: don't forget to add an item to the Breaking Changes section about this. 🙂 (Users who've used pad before will have their codes break.)

Also, at a first glance, it will likely break tutorial_multiclass_classification.py in the QML repo.

@antalszava, Thanks for the reminder! I will update the change log! I can also update the demo!

[rmoyard]

It looks good to me, I don't why coverage is complaining. Can you check it locally?

[Jaybsoni]

Local coverage report:

branch: master

branch: deprecate_pad_arg

Not sure why the overall coverage has decreased since the coverage for the amplitude.py file increased. I think this is good to merge? @josh146, @antalszava any ideas on what could be missing or can we just merge it?

[rmoyard]

@Jaybsoni Normally it is just because more lines were deleted than added and CodeCoverage does not like that!

[Jaybsoni]

@Jaybsoni Normally it is just because more lines were deleted than added and CodeCoverage does not like that!

I see! Well in that case I think its good to go. Let me know if there is anything else you think needs to be changed

[rmoyard]

It looks good to me :100 @josh146 In my opinion you can bypass the coverage check

[josh146]

Normally it is just because more lines were deleted than added and CodeCoverage does not like that!

We should probably read through the codecov documentation, maybe there is a setting we can change in our codecov configuration file to avoid this from happening 🤔