Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Batching to BasicEntangerLayers #1883

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Conversation

puzzleshark
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1883 (ab3c230) into master (b9c922b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1883   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         224      224           
  Lines       17102    17104    +2     
=======================================
+ Hits        16904    16906    +2     
  Misses        198      198           
Impacted Files Coverage Δ
pennylane/templates/layers/basic_entangler.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c922b...ab3c230. Read the comment docs.

@puzzleshark puzzleshark linked an issue Nov 10, 2021 that may be closed by this pull request
@puzzleshark puzzleshark changed the title [WIP] Added Batching to BasicEntangerLayers Added Batching to BasicEntangerLayers Nov 10, 2021
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @puzzleshark! Looks good, I just left a few comments/suggestions

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/templates/layers/basic_entangler.py Outdated Show resolved Hide resolved
pennylane/templates/layers/basic_entangler.py Outdated Show resolved Hide resolved
pennylane/templates/layers/basic_entangler.py Show resolved Hide resolved
tests/templates/test_layer.py Outdated Show resolved Hide resolved
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just curious about questions/suggestions that Tom has also raised.

tests/transforms/test_batch_params.py Outdated Show resolved Hide resolved
@antalszava
Copy link
Contributor

[sc-11222]

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @puzzleshark, overall looking good! 🙂 Had two minor change suggestions and two questions, but this looks to be nearing the finish line from my side. 🎉

Note: there seems to be a conflict with master in the changelog.

pennylane/templates/layers/basic_entangler.py Outdated Show resolved Hide resolved
pennylane/templates/layers/basic_entangler.py Outdated Show resolved Hide resolved
tests/templates/test_layer.py Outdated Show resolved Hide resolved
tests/transforms/test_batch_params.py Outdated Show resolved Hide resolved
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @puzzleshark!

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Thanks

BasicEntanglerLayers now supports `batch_params` decorator.
@puzzleshark puzzleshark merged commit 67ad2d3 into master Nov 25, 2021
@puzzleshark puzzleshark deleted the batch-basic-entangled branch November 25, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add batching support to the BasicEntanglerLayers template
3 participants