Update matplotlib circuit drawing to work with matplotlib v3.5 #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Nov 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
- Coverage 98.98% 98.98% -0.01%
==========================================
Files 219 219
Lines 16513 16512 -1
==========================================
- Hits 16345 16344 -1
Misses 168 168
Continue to review full report at Codecov.
|
josh146
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI tests were failing when matplotlib updated to version 3.5.
Now, the
arrowin the measurement box was added twice to the axes. I therefore use a different call signature.ax.arrowcreates the arrow and adds them to the axes. Before, I created them and then manually added it to the axes.