Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elimate requires_grad=True warnings from device tests #1913

Merged
merged 9 commits into from
Nov 19, 2021
Merged

Elimate requires_grad=True warnings from device tests #1913

merged 9 commits into from
Nov 19, 2021

Conversation

dime10
Copy link
Contributor

@dime10 dime10 commented Nov 18, 2021

Small PR to remove requires_grad=True warnings from the device tests in:

  • tests/devices
  • pennylane/devices/tests

These warnings were introduced in anticipation of Pennylane v0.20.0 making the default requires_grad=False for variational parameters.

@dime10 dime10 requested a review from albi3ro November 18, 2021 17:15
@dime10
Copy link
Contributor Author

dime10 commented Nov 18, 2021

[sc-11205]

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #1913 (abc3eea) into master (9cf401d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1913   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         222      222           
  Lines       16979    16979           
=======================================
  Hits        16781    16781           
  Misses        198      198           
Impacted Files Coverage Δ
pennylane/ops/qubit/non_parametric_ops.py 97.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf401d...abc3eea. Read the comment docs.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :)

Just needs a changelog entry and I'll approve.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) Just the one spelling thing.

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
@dime10 dime10 merged commit 64901ef into PennyLaneAI:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants