Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to Squeezing and Displacement Embeddings #1920

Merged
merged 14 commits into from
Nov 22, 2021

Conversation

ankit27kh
Copy link
Contributor

Description of the Change:
add examples to Squeezing and Displacement Embeddings
Benefits:
better documentation
Possible Drawbacks:
none
Related GitHub Issues:
#1727 #1735

add example in documentation
add example to documentation
@ankit27kh
Copy link
Contributor Author

Hi @antalszava, this should be complete.
These two were very similar; thus, I have used the same documentation for both while only changing the embedding itself.

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀 Applying some small suggestions, then ready to merge 🚢

pennylane/templates/embeddings/displacement.py Outdated Show resolved Hide resolved
pennylane/templates/embeddings/displacement.py Outdated Show resolved Hide resolved
pennylane/templates/embeddings/squeezing.py Outdated Show resolved Hide resolved
pennylane/templates/embeddings/squeezing.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1920 (2ff4081) into master (64901ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1920   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         222      222           
  Lines       16979    16979           
=======================================
  Hits        16781    16781           
  Misses        198      198           
Impacted Files Coverage Δ
pennylane/templates/embeddings/displacement.py 100.00% <ø> (ø)
pennylane/templates/embeddings/squeezing.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64901ef...2ff4081. Read the comment docs.

pennylane/templates/embeddings/squeezing.py Outdated Show resolved Hide resolved
pennylane/templates/embeddings/squeezing.py Outdated Show resolved Hide resolved
pennylane/templates/embeddings/displacement.py Outdated Show resolved Hide resolved
pennylane/templates/embeddings/displacement.py Outdated Show resolved Hide resolved
@antalszava antalszava merged commit 7eaa801 into PennyLaneAI:master Nov 22, 2021
@ankit27kh ankit27kh deleted the patch-2 branch November 24, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants