Fixes a test in the device test suite #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Nov 26, 2021
rmoyard
reviewed
Nov 26, 2021
There was a problem hiding this comment.
Thanks @albi3ro for catching this, there is a problem with the following operation
"QubitDensityMatrix": qml.QubitStateVector(np.array([[0.5, 0.0], [0, 0.5]]), wires=[0])
I think you should extend it to 4 wires as it is defined in the device.
Codecov Report
@@ Coverage Diff @@
## master #1943 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 225 225
Lines 17167 17167
=======================================
Hits 16963 16963
Misses 204 204 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
pennylane/devices/tests/test_gates.py, the testtest_supported_gates_can_be_implementedwas creating an empty circuit and not applying the actual gate, since the operation was instantiated outside the QNode.