-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename circuit_drawer
module to drawer
#1949
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1949 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 225 225
Lines 17167 17168 +1
=======================================
+ Hits 16963 16964 +1
Misses 204 204
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @albi3ro!
circuit_drawer
contains only developer-facing code. Do we need to import drawer ascircuit_drawer
as well and raise a UserWarning about the old path?
Probably not needed, since this module was not user facing.
from pennylane.drawer import tape_mpl | ||
from pennylane.wires import Wires |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this was changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While double-checking import paths, I saw qml
was only used twice. At that number it's cleaner and more performant to just import directly what we need.
Co-authored-by: Josh Izaac <josh146@gmail.com>
circuit_drawer
was the only module with an underscore in it, and thecircuit
part of the name is fairly redundant. What else would we be drawing in PennyLane?So we are shortening the name to the equally informative
drawer
.circuit_drawer
contains only developer-facing code. Do we need to importdrawer
ascircuit_drawer
as well and raise aUserWarning
about the old path?