Add active wire notches to matplotlib drawings #1954
Conversation
|
Hello. You may have forgotten to update the changelog!
|
albi3ro
added
the
review-ready 👌
Codecov Report
@@ Coverage Diff @@
## master #1954 +/- ##
==========================================
+ Coverage 96.86% 98.80% +1.94%
==========================================
Files 225 225
Lines 17123 17144 +21
==========================================
+ Hits 16586 16939 +353
+ Misses 537 205 -332
Continue to review full report at Codecov.
|
| def test_decimals(): | ||
| """Test decimals changes operation labelling""" | ||
| def test_decimals(self): | ||
| """Test decimals changes operation labelling""" | ||
|
|
There was a problem hiding this comment.
From this test I understand that if I have RX(2), in the final drawing I should see RX(2), however, when I run it I only see RX.
There was a problem hiding this comment.
(Just a question, I didn't want to modify the code.)
There was a problem hiding this comment.
f you want RX(2), you should use the decimals=0 keyword. decimals=None is the default and doesn't include any parameters.
There was a problem hiding this comment.
From the documentation:
decimals (int): How many decimal points to include when formatting operation parameters.
Default ``None`` will omit parameters from operation labels.
There was a problem hiding this comment.
Ah ok, I was waiting by default to see it, but you're right 👍🙂
|
[sc-12054] |
Currently for multiwire gates,
qml.drawer.MPLDrawerdraws a box covering everything from the minimum wire to the maximum wire. This makes it impossible to tell which gates are actually used by the gate and which ones just happen to be placed between active wires.This PR adds fancy boxes (rounded edges) at the edge of the gate box on the active wires. If all the "covered" wires are active, then no notches are drawn. Notches on active wires are only drawn if inactive wires exist.
It can be turned off via the keyword argument
active_wire_notches = Falsetoqml.draw_mpl,qml.drawer.tape_mpl, andqml.drawer.MPLDrawer.box_gate.