Update the device argument to the qnode decorator
#1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to having a `device` argument instead of `dev`. The reason is that having the argument be called `dev` doesn't provide backwards compatibility. (See [failing QML demonstration](https://github.com/PennyLaneAI/qml/runs/4367411103?check_suite_focus=true#step:8:2501) here.)
|
Hello. You may have forgotten to update the changelog!
|
antalszava
commented
Dec 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #1969 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 226 226
Lines 17348 17348
=======================================
Hits 17143 17143
Misses 205 205
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to having a
deviceargument instead ofdev. The reason is that having the argument be calleddevdoesn't provide backwards compatibility. (See failing QML demonstration here that failed because@qml.qnode(device=dev).)