Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the pennylane/measure.py file to pennylane/measurements.py #2236

Merged
merged 7 commits into from
Mar 1, 2022

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Feb 26, 2022

Context:
In preparations to introduce the user interface for mid-circuit measurements (see #2211), we'd like to allow qml.measure to be an accessible name.

Description of the Change:

Carries out the pennylane/measure.py -> pennylane/measurements.py renaming.

Benefits:

qml.measure will be a vacant name to use and no conflicts arise.

Possible Drawbacks:

Minor: plugins or demos might be dependent on the renaming, however, no such occurrences have been found so far.

Related GitHub Issues:
N/A

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #2236 (19bb467) into master (5a6c2f5) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 19bb467 differs from pull request most recent head 53abc95. Consider uploading reports for the commit 53abc95 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2236      +/-   ##
==========================================
+ Coverage   99.21%   99.27%   +0.05%     
==========================================
  Files         232      231       -1     
  Lines       18559    18379     -180     
==========================================
- Hits        18413    18245     -168     
+ Misses        146      134      -12     
Impacted Files Coverage Δ
pennylane/measurements.py 99.07% <ø> (ø)
pennylane/transforms/hamiltonian_expand.py 100.00% <ø> (ø)
pennylane/__init__.py 100.00% <100.00%> (ø)
pennylane/_device.py 97.98% <100.00%> (+0.01%) ⬆️
pennylane/_qubit_device.py 98.72% <100.00%> (+<0.01%) ⬆️
pennylane/circuit_graph.py 95.00% <100.00%> (+0.53%) ⬆️
pennylane/drawer/representation_resolver.py 99.43% <100.00%> (+<0.01%) ⬆️
pennylane/gradients/parameter_shift.py 100.00% <100.00%> (ø)
pennylane/gradients/parameter_shift_cv.py 99.16% <100.00%> (ø)
pennylane/operation.py 95.99% <100.00%> (+0.06%) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6c2f5...53abc95. Read the comment docs.

@antalszava
Copy link
Contributor Author

Merging this as the codefactor issues are unrelated to this PR and are being addressed in #2258.

@antalszava antalszava merged commit b494a2b into master Mar 1, 2022
@antalszava antalszava deleted the rename_measure_py branch March 1, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants