Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move expand function from Operation to Operator #2239

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Conversation

mariaschuld
Copy link
Contributor

possible drawbacks: I could not find any logic that relies on the expand function identifying Operations (as opposed to Observables) and hope this is safe. In any case, this should not be logic that is used!

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #2239 (718ba22) into master (9b61f17) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2239   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files         231      231           
  Lines       18349    18349           
=======================================
  Hits        18215    18215           
  Misses        134      134           
Impacted Files Coverage Δ
pennylane/operation.py 95.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b61f17...718ba22. Read the comment docs.

Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mariaschuld!

@mariaschuld mariaschuld merged commit c4b18f0 into master Feb 28, 2022
@mariaschuld mariaschuld deleted the move-expand branch February 28, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants