-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix queuing unexpected operators with qml.measure
#2328
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2328 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 242 242
Lines 19190 19193 +3
=======================================
+ Hits 19060 19063 +3
Misses 130 130
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it very well! 👍😊
Co-authored-by: Guillermo Alonso-Linaje <65235481+KetpuntoG@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
qml.measure
Context:
The conditional measurement added gates that were not defined.
Description of the Change:
Following the @antalszava 's suggestion I just changed
tape.queue
fortape.operations + tape.measurements
. The issue originally was thattape.queue
contains the underlying annotated queue that doesn't describe the circuit itself. Instead, a circuit would have to be iterated usingtape.operations + tape.measurements
.Related GitHub Issues:
(#2327)