Skip identities in default.mixed #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Mar 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 243 243
Lines 18322 18324 +2
=======================================
+ Hits 18216 18218 +2
Misses 106 106
Continue to review full report at Codecov.
|
antalszava
approved these changes
Mar 22, 2022
Comment on lines
+820
to
+824
| initialstate = dev.state.__copy__() | ||
|
|
||
| dev._apply_operation(op) | ||
|
|
||
| assert qml.math.allclose(dev.state, initialstate) |
There was a problem hiding this comment.
How come the state is being copied here (as opposed to default.qubit where we could compare using is)?
There was a problem hiding this comment.
dev._apply_operation updates dev.state itself. So So I have to copy the initial state to be able to compare it later. Since it's copied, I can't use is, as is checks whether its the exact same thing at the same location.
Co-authored-by: antalszava <antalszava@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2356 , this PR makes
"default.mixed"skip identities as well.