Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if qml.probs is called without wires or obs #2438

Merged
merged 9 commits into from
Apr 13, 2022

Conversation

antalszava
Copy link
Contributor

Closes #2401.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@antalszava antalszava requested a review from rmoyard April 12, 2022 16:16
@antalszava
Copy link
Contributor Author

[sc-17088]

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antalszava it looks good to me! 💯

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #2438 (ce3e3f1) into master (afc9adc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2438   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files         242      242           
  Lines       18971    18973    +2     
=======================================
+ Hits        18868    18870    +2     
  Misses        103      103           
Impacted Files Coverage Δ
pennylane/measurements.py 99.43% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc9adc...ce3e3f1. Read the comment docs.

@antalszava antalszava changed the title Add raising an error if qml.probs called without wires or obs Raise an error if qml.probs is called without wires or obs Apr 13, 2022
@antalszava antalszava merged commit f418eb6 into master Apr 13, 2022
@antalszava antalszava deleted the fix_probs_empty branch April 13, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] qml.probs() (no wires) fails with shots=None
2 participants