Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix commuting evolution bug #2542

Merged
merged 5 commits into from
May 6, 2022
Merged

fix commuting evolution bug #2542

merged 5 commits into from
May 6, 2022

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented May 5, 2022

Fixes #2520

There was some confusion as to the parameters, and during expansion, both ApproxTimeEvolution and its decomposition were being queued.

@albi3ro albi3ro requested a review from josh146 May 5, 2022 18:28
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2542 (dd11f25) into master (d981044) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2542   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         243      243           
  Lines       19438    19438           
=======================================
  Hits        19355    19355           
  Misses         83       83           
Impacted Files Coverage Δ
...ylane/templates/subroutines/commuting_evolution.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d981044...dd11f25. Read the comment docs.

@albi3ro
Copy link
Contributor Author

albi3ro commented May 5, 2022

[sc-18955]

@albi3ro albi3ro requested a review from antalszava May 5, 2022 20:18
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome catch! 🎉 One more test case could be nice to add. The example from the issue executes well locally.

Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @albi3ro!

@albi3ro albi3ro merged commit 47e85c5 into master May 6, 2022
@albi3ro albi3ro deleted the commuting_evolution branch May 6, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Derivatives of qml.CommutingEvolution
3 participants