-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix commuting evolution bug #2542
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2542 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 243 243
Lines 19438 19438
=======================================
Hits 19355 19355
Misses 83 83
Continue to review full report at Codecov.
|
[sc-18955] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome catch! 🎉 One more test case could be nice to add. The example from the issue executes well locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix @albi3ro!
Fixes #2520
There was some confusion as to the parameters, and during expansion, both
ApproxTimeEvolution
and its decomposition were being queued.