-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove do_queue
argument from Operation.adjoint
#2583
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2583 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 243 243
Lines 19595 19595
=======================================
Hits 19514 19514
Misses 81 81
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straight forward! Would this be removing the ability to control if an adjoint operation is queued completely, or would we just move that functionality to the Adjoint wrapper class?
It might be good to check (I'm not sure) if there are any tests that need to be updated or removed that check for queuing of the adjoint of these operations. But other then that I think its good to go
Obviously, this keyword was completely untested, as I could remove it without breaking any tests. Also, the most common operations already had it removed, leading to lots of manually silenced linting complaints. |
The
Operation.adjoint
method currently has ado_queue
keyword that is not used for anything and is usually left out of child implementations.This PR standardizes the removal of the
do_queue
keyword.