-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localise and decrease openfermion-dependency in qchem tests #2593
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2593 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 243 243
Lines 19630 19630
=======================================
Hits 19550 19550
Misses 80 80 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left two unrelated comments. Also, any idea why doc build is failing? 🤔
Found out it is because of protobuf
4.21.0
.
It is passing after a rerun. |
Context:
This PR localises the openfermion-dependent tests in one place and reduces openfermion dependency in qchem tests where possible.
Description of the Change:
All openfermion-dependent tests are now located in
of_tests
.The new module
test_structure
is created to collect the tests of theqchem.structure
module in one place. These tests were previously insideof_tests
and had some openfermion dependency which is now removed.The rest of the qchem tests are brought inside
tests.qchem
.Benefits:
Makes it easier to manage the external dependencies in the qchem tests.
Possible Drawbacks:
Related GitHub Issues: