Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsingXY [unitaryhack] #2649

Merged
merged 43 commits into from
Jun 7, 2022
Merged

Add IsingXY [unitaryhack] #2649

merged 43 commits into from
Jun 7, 2022

Conversation

ankit27kh
Copy link
Contributor

Context:
Add IsingXY gate
Description of the Change:
Adds the gate and related methods and tests.
Benefits:
Now supports IsingXY
Possible Drawbacks:
N/A
Related GitHub Issues:
Closes #2559

@codecov
Copy link

codecov bot commented Jun 2, 2022 •
edited
Loading

Codecov Report

Merging #2649 (9107ef5) into master (c6e7ca6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2649   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         249      249           
  Lines       20150    20185   +35     
=======================================
+ Hits        20067    20102   +35     
  Misses         83       83
Impacted Files Coverage Δ
pennylane/devices/default_qubit.py 100.00% <ø> (ø)
pennylane/ops/qubit/__init__.py 100.00% <ø> (ø)
pennylane/ops/qubit/parametric_ops.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e7ca6...9107ef5. Read the comment docs.

@rmoyard
Copy link
Contributor

rmoyard commented Jun 3, 2022

Hi @ankit27kh ! Thank you for your contribution, let me know when it is ready for review.

@ankit27kh
Copy link
Contributor Author

hey @rmoyard it is ready for review. you can take a look

@ankit27kh ankit27kh changed the title Add isingxy Add IsingXY [unitaryhack] Jun 3, 2022
rmoyard
rmoyard reviewed Jun 3, 2022
View reviewed changes
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ankit27kh, you are on a very good way! It misses some coverage and I added some comments.

pennylane/ops/qubit/parametric_ops.py Outdated Show resolved Hide resolved
pennylane/ops/qubit/parametric_ops.py Outdated Show resolved Hide resolved
pennylane/ops/qubit/parametric_ops.py Show resolved Hide resolved
tests/ops/qubit/test_parametric_ops.py Outdated Show resolved Hide resolved
@chaeyeunpark chaeyeunpark mentioned this pull request Jun 6, 2022
Closed
@rmoyard rmoyard mentioned this pull request Jun 7, 2022
Closed
rmoyard
rmoyard reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ankit27kh, some minor comments to be solved. After that I am happy to approve the PR 💯

tests/ops/qubit/test_parametric_ops.py Show resolved Hide resolved
tests/ops/qubit/test_parametric_ops.py Show resolved Hide resolved
tests/ops/qubit/test_parametric_ops.py Show resolved Hide resolved
tests/ops/qubit/test_parametric_ops.py Show resolved Hide resolved
tests/ops/qubit/test_parametric_ops.py Show resolved Hide resolved
tests/ops/qubit/test_parametric_ops.py Outdated Show resolved Hide resolved
tests/ops/qubit/test_parametric_ops.py Outdated Show resolved Hide resolved
tests/ops/qubit/test_parametric_ops.py Outdated Show resolved Hide resolved
rmoyard
rmoyard reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, can you retrigger the CI checks with git commit --allow-empty -m "Trigger CI" and pushing again.

@rmoyard
Copy link
Contributor

rmoyard commented Jun 7, 2022

Sorry @ankit27kh we reached a concurrency limit again, can you redo it? Thank you!

@ankit27kh
Copy link
Contributor Author

Hey @rmoyard, it's finished

rmoyard
rmoyard approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats @ankit27kh, PR accepted 💯

@rmoyard rmoyard added the unitaryhack-accepted This contribution has been accepted for a UnitaryHack issue label Jun 7, 2022
@rmoyard rmoyard merged commit a4a6fda into PennyLaneAI:master Jun 7, 2022
@ankit27kh ankit27kh deleted the add_isingxy branch June 7, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoyard rmoyard rmoyard approved these changes

Assignees
No one assigned
Labels
unitaryhack-accepted This contribution has been accepted for a UnitaryHack issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding IsingXY operation
2 participants
@ankit27kh @rmoyard