Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjoint ops to device test suite #2658

Merged
merged 6 commits into from
Jun 6, 2022
Merged

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Jun 3, 2022

While #2222 added default.qubit support for several non-decomposable Adjoint gates, they were not added to the device test suite. This PR adds the following ops to the device test suite:

  • adjoint(S)
  • adjoint(T)
  • adjoint(SX)
  • adjoint(SISWAP)
  • adjoint(ISWAP)

@albi3ro albi3ro added the op-arithmetic PR's involved in introducing operator arithmetic label Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #2658 (c5e8d3a) into master (43fc4f6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #2658    +/-   ##
========================================
  Coverage   99.58%   99.58%            
========================================
  Files         248      249     +1     
  Lines       19985    20135   +150     
========================================
+ Hits        19902    20052   +150     
  Misses         83       83            
Impacted Files Coverage Δ
pennylane/math/single_dispatch.py 98.86% <ø> (ø)
pennylane/ops/op_math/__init__.py 100.00% <100.00%> (ø)
pennylane/ops/op_math/pow_class.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1058cad...c5e8d3a. Read the comment docs.

@albi3ro albi3ro requested a review from rmoyard June 6, 2022 14:55
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the adjoint operations to the tests 💯 It looks good to me!

@albi3ro albi3ro merged commit c1db150 into master Jun 6, 2022
@albi3ro albi3ro deleted the device-suite-adjoint-gates branch June 6, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
op-arithmetic PR's involved in introducing operator arithmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants