Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use einsum_v2 instead of einsum_v1 for Tensorflow #2683

Merged
merged 7 commits into from
Jun 9, 2022
Merged

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Jun 9, 2022

Context:

tf.einsum is currently replace by its version einsum_v1 for compatibility with TensorFlow 2.1.~

Description of the Change:

Remove the restriction and use tf.einsum.

Benefits:

Support new tf.einsum functionnalities.

Possible Drawbacks:

PennyLane does not support TensorFlow 2.1.~ anymore

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2683 (cc3cdf2) into master (bee93e4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2683   +/-   ##
=======================================
  Coverage   99.59%   99.60%           
=======================================
  Files         249      249           
  Lines       20280    20275    -5     
=======================================
- Hits        20197    20194    -3     
+ Misses         83       81    -2     
Impacted Files Coverage Δ
pennylane/devices/default_qubit_tf.py 95.31% <ø> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee93e4...cc3cdf2. Read the comment docs.

@rmoyard rmoyard requested a review from dime10 June 9, 2022 20:56
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rmoyard rmoyard merged commit f2787bf into master Jun 9, 2022
@rmoyard rmoyard deleted the update_tf_einsum branch June 9, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants