[QIM-8] quantum fisher information (new) #2684
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 251 251
Lines 20675 20682 +7
=======================================
+ Hits 20595 20602 +7
Misses 80 80
Continue to review full report at Codecov.
|
| # TODO: ``hardware`` argument will be obsolete in future releases when ``shots`` can be inferred. | ||
| if hardware: |
There was a problem hiding this comment.
@eddddddy / @Qottmann: I think we should be able to infer this :) Via something like:
if qnode.device.shots is not None:I think it might be best to make this change in the feature freeze week, for two reasons:
- Consistency with the rest of PennyLane (where there is no
hardwareoption) - Because, more accurately, the logic here is more about 'are shots finite', rather than 'is the device hardware'. There will be cases where you are using a simulator, but will be using finite shots, so this may confuse the reader!
| if hardware: | ||
|
|
||
| def wrapper(*args0, **kwargs0): | ||
| return 4 * metric_tensor(qnode, *args, **kwargs)(*args0, **kwargs0) |
There was a problem hiding this comment.
It is assumed here that qnode is a QNode, so you'll need to update the docstring to remove mention of the tape!
Context:
Setting up a new PR of the previous (2676) due to many changes that underwent in the previous branches.