-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module documentation for ops
#2730
Merged
Merged
Changes from 88 commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
30650a6
Update phase decomp test (#2697)
antalszava 333541b
Update interfaces.rst (#2698)
antalszava b524f25
Allow templates to be decomposed (#2704)
eddddddy cb85618
Deprecate `qml.ExpvalCost` (#2571)
Qottmann d0cb387
Update JAX jit forward mode forward evaluation (#2700)
antalszava 76e3fa3
Improve ising gates documentation (#2711)
rmoyard 8c39317
Support classical fisher gradients when using Autograd (#2688)
josh146 34dc494
Support classical Fisher gradients when using TF and torch (#2710)
eddddddy 9ba938b
Remove `hardware` argument in `qml.qinfo.quantum_fisher` (#2695)
Qottmann 96da6bd
Add `qinfo` measurements in supported configurations docs (#2712)
eddddddy e5a3ac3
Use access_state (#2719)
antalszava c036f79
Update docs v0.24 (#2724)
antalszava 1d45127
Move summary to start (#2727)
eddddddy ddaa9d2
add ops module section
albi3ro b5080a8
only include functions and op_math
albi3ro 1bb564d
added weights initialization example (#2735)
Qottmann 4886673
Merge branch 'v0.24.0-rc0' into ops-module-docs
Jaybsoni 40469ec
Wires not updated for a hamiltonian with in-place addition (#2738)
Jaybsoni cf69743
Merge branch 'v0.24.0-rc0' into ops-module-docs
Jaybsoni 14737ea
try other way
albi3ro ef91cb2
try other way
albi3ro bf39ac0
Cleanup docs (#2736)
eddddddy a756e54
Documentation changes for `batch_partial` (#2737)
eddddddy 64e5fb6
Merge branch 'v0.24.0-rc0' into ops-module-docs
albi3ro 30d59c0
Fix sphinx class/method links (#2729)
dime10 666cae5
Merge branch 'v0.24.0-rc0' into ops-module-docs
rmoyard 9dc5663
trying something else
albi3ro 0778b2e
Fix rendering of matrix rep of ECR (#2741)
Jaybsoni e0e001d
Merge branch 'v0.24.0-rc0' into ops-module-docs
Jaybsoni 9a07e07
Fix doc quantum information and ising (#2732)
rmoyard 8100968
hope
albi3ro 86d5a56
Merge branch 'ops-module-docs' of https://github.com/PennyLaneAI/penn…
albi3ro f798b58
Merge branch 'v0.24.0-rc0' into ops-module-docs
albi3ro 3cafe56
Add quantum info measurements to introduction doc page (#2734)
albi3ro a21d846
maybe this time
albi3ro c8e1dda
probably not going to work but worth a try
albi3ro a6f69c1
Merge branch 'v0.24.0-rc0' into ops-module-docs
albi3ro 58e96e0
Apply suggestions from code review
albi3ro 7c9ede8
update with master
albi3ro dc7422f
Merge branch 'master' into ops-module-docs
albi3ro c78a42a
updates
albi3ro 9740775
merge something
albi3ro de50fb5
Merge branch 'ops-module-docs' of https://github.com/PennyLaneAI/penn…
albi3ro 142196b
update docstring
albi3ro d6df57f
line length problem
albi3ro 29f70aa
Merge branch 'master' into ops-module-docs
albi3ro 63bee53
Merge branch 'master' into ops-module-docs
albi3ro 5a73282
fix controlled signature
albi3ro 450915b
fix s_prod
albi3ro 219914f
add control class notes
albi3ro 157aca1
Merge branch 'master' into ops-module-docs
Jaybsoni a5988d3
update docs for Sprod and Sum
Jaybsoni c38a046
Merge branch 'master' into ops-module-docs
Jaybsoni cbd69d4
typo
Jaybsoni 81f6aa6
Merge branch 'ops-module-docs' of https://github.com/PennyLaneAI/penn…
Jaybsoni 12edb92
small fix
Jaybsoni 4da67a2
fixing docs
Jaybsoni 40fbbba
added pragma no-cover to signature property
Jaybsoni d29d10c
Merge branch 'master' into ops-module-docs
Jaybsoni 76fd92e
Merge branch 'master' into ops-module-docs
Jaybsoni f0902ba
Apply suggestions from code review
Jaybsoni 9b6427e
clean up
Jaybsoni 419dcae
Merge branch 'master' into ops-module-docs
Jaybsoni 6981376
fix sprod demo
Jaybsoni 21fa5a4
Merge branch 'ops-module-docs' of https://github.com/PennyLaneAI/penn…
Jaybsoni 408eedf
Merge branch 'master' into ops-module-docs
Jaybsoni 929b7b1
add info to quick start operations guide
Jaybsoni ff42631
Merge branch 'ops-module-docs' of https://github.com/PennyLaneAI/penn…
Jaybsoni e83c454
typo
Jaybsoni f41a7ba
added example
Jaybsoni cb07d5f
Merge branch 'master' into ops-module-docs
Jaybsoni be4b551
Merge branch 'master' into ops-module-docs
Jaybsoni 7ea822b
re-link top level imports to prevent duplication of docstring pages g…
Jaybsoni f098547
Merge branch 'ops-module-docs' of https://github.com/PennyLaneAI/penn…
Jaybsoni fa5983c
typo
Jaybsoni 06e8efc
Merge branch 'master' into ops-module-docs
Jaybsoni ff5341b
change constructor imports to toplevel
Jaybsoni 8336df7
Merge branch 'ops-module-docs' of https://github.com/PennyLaneAI/penn…
Jaybsoni a8b7826
Merge branch 'master' into ops-module-docs
Jaybsoni a3efeb4
Apply suggestions from code review
Jaybsoni dcfc891
add equal to ops.functions docstring
albi3ro 8c2ce94
Merge branch 'master' into ops-module-docs
Jaybsoni 043f7de
Merge branch 'v0.25.0-rc0' into ops-module-docs
albi3ro 8f3cd2a
Update doc/introduction/operations.rst
Jaybsoni ff476b8
Update pennylane/ops/op_math/controlled_class.py
Jaybsoni a989c9a
Update pennylane/ops/op_math/sum.py
Jaybsoni 3ee42af
Merge branch 'v0.25.0-rc0' into ops-module-docs
Jaybsoni b590e2a
Merge branch 'v0.25.0-rc0' into ops-module-docs
Jaybsoni 34dd5af
lint
Jaybsoni 287fafa
Merge branch 'v0.25.0-rc0' into ops-module-docs
Jaybsoni d71f15f
Merge branch 'v0.25.0-rc0' into ops-module-docs
Jaybsoni 9d1aa71
Merge branch 'v0.25.0-rc0' into ops-module-docs
Jaybsoni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
qml.ops.op_math | ||
=============== | ||
|
||
.. automodule:: pennylane.ops.op_math |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it might be confusing having separate
ops/functions
andops/op_math
going forward? There might be edge cases where it's not clear to a developer which file to add the feature to.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already confusing. The
simplify
function could go in either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree - should we just merge them? Have a single place for generic functions of operators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tend to group things in PennyLane by what type of object they are: functions, classes, tranforms, etc. We should instead start grouping things by dependencies, interactions, and responsibilities. But there's no good, clear cut answer on where to put things, especially in a language as flexible as Python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep for sure, it is not an easy problem to solve. My short term thinking was to avoid developer overhead that we already see with operations vs. templates ("should I add this to operations or templates?")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-working the docs might be a good epic to add in the future since I imagine this will require moving multiple functions and classes around.