New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMP #5: Add Sample
MP class
#3288
Conversation
Hello. You may have forgotten to update the changelog!
|
…e into measurement-process
Codecov Report
@@ Coverage Diff @@
## master #3288 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 298 298
Lines 26163 26188 +25
=======================================
+ Hits 26085 26110 +25
Misses 78 78
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @AlbertMitjans 💯
_Sample
class (name will be changed toSample
after the whole refactor)._Sample
instance inqml.sample
.QubitDevice.sample
into_Sample.process
+ improve code style.teardown_method
to thetest_sample.py
tests that checks thatQubitDevice.sample
and_Sample.process
return the same values for all tests.