New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add canonical 2-complete linear swap network #3447
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3447 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 311 313 +2
Lines 27933 27984 +51
=======================================
+ Hits 27897 27948 +51
Misses 36 36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I will remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! I left a lot of comments and suggestions and I'm requesting changes. But I think they shouldn't be too hard to address. They're smaller problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few more comments, but I approve as soon as those are addressed. Everything works really well, it just takes some time to read through and understand how to use the SWAP network to do specific things.
Context: Adds 2-CCL swap network described in arXiv:1905.05118
Description of the Change: Adds a new template category for the swap network
Benefits:
Possible Drawbacks: N/A
Related GitHub Issues:: N/A