Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical 2-complete linear swap network #3447

Merged
merged 31 commits into from Dec 21, 2022

Conversation

obliviateandsurrender
Copy link
Contributor

Context: Adds 2-CCL swap network described in arXiv:1905.05118

Description of the Change: Adds a new template category for the swap network

Benefits:

Possible Drawbacks: N/A

Related GitHub Issues:: N/A

@obliviateandsurrender obliviateandsurrender added WIP 🚧 Work-in-progress templates 📁 Updates and additions to the templates do not merge ⚠️ Do not merge the pull request until this label is removed and removed do not merge ⚠️ Do not merge the pull request until this label is removed labels Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #3447 (29f160b) into master (e2e23e5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3447   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files         311      313    +2     
  Lines       27933    27984   +51     
=======================================
+ Hits        27897    27948   +51     
  Misses         36       36           
Impacted Files Coverage Δ
pennylane/__init__.py 96.73% <100.00%> (+0.03%) ⬆️
pennylane/templates/__init__.py 100.00% <100.00%> (ø)
pennylane/templates/swapnetworks/__init__.py 100.00% <100.00%> (ø)
pennylane/templates/swapnetworks/ccl2.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@obliviateandsurrender
Copy link
Contributor Author

I will remove the FermionicSWAP code from here once the previous PR gets merged.

Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! I left a lot of comments and suggestions and I'm requesting changes. But I think they shouldn't be too hard to address. They're smaller problems.

doc/introduction/templates.rst Show resolved Hide resolved
doc/introduction/templates.rst Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/__init__.py Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few more comments, but I approve as soon as those are addressed. Everything works really well, it just takes some time to read through and understand how to use the SWAP network to do specific things.

doc/introduction/templates.rst Show resolved Hide resolved
doc/releases/changelog-dev.md Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/__init__.py Outdated Show resolved Hide resolved
pennylane/templates/__init__.py Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
pennylane/templates/swap_networks/ccl2.py Outdated Show resolved Hide resolved
@obliviateandsurrender obliviateandsurrender merged commit 7ba586f into master Dec 21, 2022
@obliviateandsurrender obliviateandsurrender deleted the two-local-swap-network branch December 21, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
templates 📁 Updates and additions to the templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants