Pylinting more tests #3620
Closed
Pylinting more tests #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #3620 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 314 314
Lines 28084 28084
=======================================
Hits 28046 28046
Misses 38 38 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
timmysilv
reviewed
Jan 10, 2023
apotapov
commented
Jan 11, 2023
added 2 commits
January 10, 2023 20:51
albi3ro
reviewed
Jan 11, 2023
timmysilv
reviewed
Jan 11, 2023
timmysilv
reviewed
Jan 11, 2023
timmysilv
reviewed
Jan 11, 2023
* skip test failing due to networkx version * Update doc/releases/changelog-dev.md * dont run qcut tests in interface runners * fix qcut return types fixture, only selectively skip * return types dont run qcut tests
Bumps [torch](https://github.com/pytorch/pytorch) from 1.11.0+cpu to 1.13.1. - [Release notes](https://github.com/pytorch/pytorch/releases) - [Changelog](https://github.com/pytorch/pytorch/blob/master/RELEASE.md) - [Commits](https://github.com/pytorch/pytorch/commits/v1.13.1) --- updated-dependencies: - dependency-name: torch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3624) * avoid using global random numbers generation in qchem * use local random number generation * Update doc/releases/changelog-dev.md * fix is_independent tests * remove spsa change, update random test * undo spsa test change
* add pre-commit hook to run pylint on tests passing pylint * skip test pre-commit if no tests are changed
…nnylane into pylint-tests-more
…into pylint-tests-more
timmysilv
reviewed
Jan 13, 2023
| too-many-arguments, | ||
| too-few-public-methods, | ||
| too-many-public-methods, | ||
| no-self-argument, |
There was a problem hiding this comment.
where was this raised? This is a funny one to hit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Adding to the work done here to start linting more of the test files: #3600
Description of the Change:
make lint-test file=./tests/math/test_density_matrices.pyBenefits:
Moar cleaner code.
Possible Drawbacks:
Disabling certain pylint rules might hide issues and doesn't actually improve the code itself. The goal with this PR is not to be super intrusive.
Related GitHub Issues: