Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate new device interface with qml.execute and autograd #3903

Merged
merged 79 commits into from May 16, 2023
Merged

Integrate new device interface with qml.execute and autograd #3903

merged 79 commits into from May 16, 2023

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Mar 14, 2023 •
edited

Now that devices.experimental.DefaultQubit2 is added to master, we need to start integrating it with the workflow.

This PR adds support to qml.execute for the autograd interface for backprop and gradient transforms. The new device will only be supported with the new return types specification.

albi3ro and others added 30 commits January 6, 2023 12:38
@albi3ro
new device interface
7de0dca
@albi3ro
adding more information
5e19b4b
@albi3ro
rename class, update vjp and jvp documentation
02abbc4
@albi3ro
Merge branch 'master' into device_interface
3ab1441
@albi3ro
rename file to device_api
718bc7e
@albi3ro
Merge branch 'master' into device_interface
f83d0c6
@albi3ro @timmysilv
Update doc/releases/changelog-dev.md
ada752c 
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
@albi3ro
rename methods, polish docstrings
094bea1
@albi3ro
Merge branch 'master' into device_interface
68a7979
@albi3ro @trbromley @rmoyard
Apply suggestions from code review
557871f 
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Romain Moyard <rmoyard@gmail.com>
@albi3ro
some clarifications and naming changes
6dce6c2
@albi3ro
rename qscript argument to circuits
0af1dee
@albi3ro
Merge branch 'master' into device_interface
3f5ebc8
@albi3ro
documentation updates
c45de72
@albi3ro
Merge branch 'master' into device_interface
c39a4c8
@albi3ro
Merge branch 'master' into device_interface
6f657be
@albi3ro
reference added ExecutionConfig class
b2f9bd0
@albi3ro
Merge branch 'master' into device_interface
cd6d175
@albi3ro
tidy call signatures and some text
2c21bcb
@albi3ro @trbromley @rmoyard
Apply suggestions from code review
3e52a7f 
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Romain Moyard <rmoyard@gmail.com>
@albi3ro
revert to quantumdevice name, add name property
b63f6c1
@albi3ro
merge
a992dda
@albi3ro
Merge branch 'master' into device_interface
34a0670
@albi3ro
add circuit to supports_derivatives method
cb6880d
@albi3ro
Merge branch 'master' into device_interface
aba9dde
@albi3ro
fix typo
09b3417
@albi3ro
Merge branch 'device_interface' of https://github.com/PennyLaneAI/pen…
6e0b5b5 
…nylane into device_interface
@albi3ro
DefaultQubit2 device added
e5ceeb4
@albi3ro
Merge branch 'master' into default-qubit-2
715e99c
@albi3ro
docstring improvementS
76caf73
rmoyard
rmoyard reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albi3ro! I have left a couple of comments. I think we should separate the execution: better for readability, coverage and testing. Also you should add the QNode test from autograd.

pennylane/interfaces/autograd.py Outdated Show resolved Hide resolved
pennylane/interfaces/execution.py Outdated Show resolved Hide resolved
pennylane/interfaces/execution.py Outdated Show resolved Hide resolved
pennylane/interfaces/execution.py Show resolved Hide resolved
pennylane/interfaces/execution.py Outdated Show resolved Hide resolved
@albi3ro albi3ro removed the review-ready 👌 PRs which are ready for review by someone from the core team. label May 3, 2023
timmysilv
timmysilv reviewed May 5, 2023
View reviewed changes
pennylane/interfaces/execution.py Outdated Show resolved Hide resolved
pennylane/interfaces/execution.py Show resolved Hide resolved
pennylane/interfaces/execution.py Show resolved Hide resolved
pennylane/interfaces/execution.py Show resolved Hide resolved
tests/interfaces/test_execute_default_qubit_2.py Outdated Show resolved Hide resolved
tests/interfaces/test_autograd_default_qubit_2.py Outdated Show resolved Hide resolved
@albi3ro albi3ro mentioned this pull request May 12, 2023
Merged
timmysilv
timmysilv approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@albi3ro albi3ro requested a review from rmoyard May 15, 2023 21:21
@albi3ro albi3ro requested a review from mudit2812 May 16, 2023 13:30
mudit2812
mudit2812 approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes Christina! 🎉

@albi3ro albi3ro merged commit 00a1972 into master May 16, 2023
43 checks passed
@albi3ro albi3ro deleted the integrate-default-qubit2 branch May 16, 2023 16:15
@timmysilv timmysilv mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudit2812 mudit2812 mudit2812 approved these changes

@timmysilv timmysilv timmysilv approved these changes

@rmoyard rmoyard Awaiting requested review from rmoyard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@albi3ro @mudit2812 @timmysilv @rmoyard