Operator
converts tuple
to np.ndarray
#4022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Operator
converts tuples tonp.ndarray
upon initialization:But it does not do the same thing with tuples. Somehow previously, operators like
BasisState
could accept tuples as their parameters, and at some point (we think inUnwrap
), they got converted to the expectednp.ndarray
. Since this no longer happens inUnwrap
, we now explicitly convert tuples to numpy arrays as well.Lightning tests used tuples, and thus expected this behaviour to still exist. Instead of changing those tests, I think it makes to continue accept tuples in addition to just lists.
Note: I moved some things around in
test_operation.py
so the tests would be a little bit better organized.