New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support variable depth in user defined ResourceOperations
#4033
Conversation
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
[sc-37602] |
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #4033 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 351 351
Lines 30867 30903 +36
=======================================
+ Hits 30783 30819 +36
Misses 84 84
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni for adding this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Tried it for a few custom operations with random resources and it worked well.
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
Context:
PL now supports defining operations with custom resource requirements. Currently, tracking resources for operations with depth > 1 is not supported and yields a
None
value.This PR adds support so that the depth is accurately computed for a workflow with custom operations.
Description of the Change:
get_depth()
method