New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dense
keyword in ParametrizedEvolution
#4079
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #4079 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 345 345
Lines 30737 30738 +1
=======================================
+ Hits 30650 30651 +1
Misses 87 87
|
Implemented the fix from google/jax#15844 and #4078 In case that solves it (and doesnt cause any unexpected behavior / failing tests), would we still want the possibility to enforce dense matrices? |
ParametrizedEvolution
Can we also have a test checking that specifying |
I'd say that's useful. Can be deprecated in the future if we don't want this to be an option anymore. |
This is blocked because we are stuck at |
Just a fly-by comment: once this PR is ready to go can we enable the GPU CI tests by adding the "gpu" label to this PR? |
Thanks, would have forgotten that! Are GPU tests running all jax tests with gpu enabled? 🤩 I always wanted to test the pulse stuff on GPU but never had the occasion |
The GPU tests for the moment only have Torch. |
Yep, as @rmoyard said only torch is supported now. We should ensure the runner installs the JAX CUDA version for this to be supported. |
ParametrizedEvolution
dense
keyword in ParametrizedEvolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix @Qottmann 💪
Three small comments :)
…o dense-evolution
…ylane into dense-evolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Qottmann !
Merging this and waiting with the change from csr to batched csr format when we have jax |
* enable dense matrices in ParametrizedEvolution operator * doc arg description * CSR -> BCSR * revert BCSR -> CSR due to being stuck on jax version 0.4.3 for the moment * add test for coverage * black * pylint * code review suggestion * test case
Hot fix for #4078 (see also google/jax#15844)
Enables a keyword
dense
to be passed toParametrizedEvolution
that enforces dense evolution, which currently automatically is enabled for more than 2 wiresEdit2: will have to wait for jax 0.4.9 support to enable BCSR, so this is a hotfix for the moment (see discussion)