Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hash and equality support to Shots #4082

Merged
merged 25 commits into from May 5, 2023
Merged

Add hash and equality support to Shots #4082

merged 25 commits into from May 5, 2023

Conversation

Jaybsoni
Copy link
Contributor

@Jaybsoni Jaybsoni commented May 4, 2023

Context:
Add support to compare two Shots instances.

@Jaybsoni Jaybsoni requested review from albi3ro and timmysilv May 4, 2023 13:58
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Jaybsoni Jaybsoni requested a review from albi3ro May 4, 2023 18:03
@Jaybsoni Jaybsoni added the review-ready 👌 PRs which are ready for review by someone from the core team. label May 4, 2023
@Jaybsoni
Copy link
Contributor Author

Jaybsoni commented May 4, 2023

[sc-37940]

@codecov
Copy link

codecov bot commented May 4, 2023 •
edited

Codecov Report

Merging #4082 (6c4ee87) into master (56bf19a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4082   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files         345      345           
  Lines       30783    30787    +4     
=======================================
+ Hits        30700    30704    +4     
  Misses         83       83
Impacted Files Coverage Δ
pennylane/measurements/shots.py 100.00% <100.00%> (ø)

albi3ro
albi3ro approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

Base automatically changed from Shots_repr to master May 5, 2023 15:43
@Jaybsoni Jaybsoni requested a review from timmysilv May 5, 2023 15:56
timmysilv
timmysilv approved these changes May 5, 2023
View reviewed changes
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
Jaybsoni and others added 2 commits May 5, 2023 14:39
@Jaybsoni @timmysilv
Update doc/releases/changelog-dev.md
f0b5480 
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
@Jaybsoni
Merge branch 'master' into Shots_eq
e286823
@Jaybsoni Jaybsoni enabled auto-merge (squash) May 5, 2023 18:40
@Jaybsoni Jaybsoni disabled auto-merge May 5, 2023 19:07
@Jaybsoni Jaybsoni enabled auto-merge (squash) May 5, 2023 21:27
@Jaybsoni Jaybsoni merged commit 5fa00cb into master May 5, 2023
43 checks passed
@Jaybsoni Jaybsoni deleted the Shots_eq branch May 5, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albi3ro albi3ro albi3ro approved these changes

@timmysilv timmysilv timmysilv approved these changes

Assignees
No one assigned
Labels
review-ready 👌 PRs which are ready for review by someone from the core team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jaybsoni @albi3ro @timmysilv