Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform #2] Transforms program #4187

Merged
merged 70 commits into from Jun 14, 2023
Merged

[Transform #2] Transforms program #4187

merged 70 commits into from Jun 14, 2023

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented May 29, 2023

Description of the Change:

This PR introduces the main object of the transform rework, the Transform Program. We introduce it as a class with mulitple methods to interact with it.

Benefits:

We can store Transform programs on the QNode.

@rmoyard
Copy link
Contributor Author

rmoyard commented May 29, 2023

[sc-36419]

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #4187 (24c92b0) into master (4777454) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #4187    +/-   ##
========================================
  Coverage   99.77%   99.77%            
========================================
  Files         347      352     +5     
  Lines       31452    31649   +197     
========================================
+ Hits        31381    31578   +197     
  Misses         71       71            
Impacted Files Coverage Δ
pennylane/fermi/fermionic.py 100.00% <ø> (ø)
pennylane/fermi/__init__.py 100.00% <100.00%> (ø)
pennylane/fermi/conversion.py 100.00% <100.00%> (ø)
pennylane/qnode.py 100.00% <100.00%> (ø)
pennylane/transforms/__init__.py 100.00% <100.00%> (ø)
pennylane/transforms/core/__init__.py 100.00% <100.00%> (ø)
pennylane/transforms/core/transform.py 100.00% <100.00%> (ø)
pennylane/transforms/core/transform_dispatcher.py 100.00% <100.00%> (ø)
pennylane/transforms/core/transform_program.py 100.00% <100.00%> (ø)

rmoyard and others added 6 commits May 31, 2023 15:30
Co-authored-by: BorjaRequena <59647767+BorjaRequena@users.noreply.github.com>
Co-authored-by: BorjaRequena <59647767+BorjaRequena@users.noreply.github.com>
Co-authored-by: BorjaRequena <59647767+BorjaRequena@users.noreply.github.com>
Co-authored-by: BorjaRequena <59647767+BorjaRequena@users.noreply.github.com>
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes Romain! I just have one question and after that I'm ready to approve.

pennylane/transforms/core/transform_dispatcher.py Outdated Show resolved Hide resolved
@timmysilv timmysilv added this to the v0.31 milestone Jun 12, 2023
@rmoyard rmoyard requested a review from mudit2812 June 12, 2023 17:44
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Romain! There's a test coverage issue, but that will need to be fixed before merging anyway so I'm happy to approve.

Copy link
Collaborator

@BorjaRequena BorjaRequena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work, @rmoyard!

@rmoyard rmoyard changed the title [#2 Transform rework] Transforms program [Transform #2] Transforms program Jun 14, 2023
Base automatically changed from transforms_dispatcher to master June 14, 2023 18:00
@rmoyard rmoyard merged commit db7392f into master Jun 14, 2023
43 checks passed
@rmoyard rmoyard deleted the transforms_program branch June 14, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants