Update tapering.py to support operator arithmetic
#4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
obliviateandsurrender
requested changes
Jun 14, 2023
There was a problem hiding this comment.
Thanks @Jaybsoni! Leaving an initial review will leave more comments after testing. Currently, tests for HF tapering and Observable tapering are missing. Overall looking good.
soranjh
reviewed
Jun 15, 2023
There was a problem hiding this comment.
Thanks @Jaybsoni, left some small comments and questions. My main points are:
- Have we change the type of input arguments in any user-facing function?
- There seems to be some inconsistency in defining the input types in the docstrings. For instance I see both
generators (list[Union[~.Hamiltonian, ~.Operator]])andgenerators (list[~.Operator]). These should be corrected if they are not.
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #4252 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 352 352
Lines 31958 31982 +24
=======================================
+ Hits 31891 31915 +24
Misses 67 67
|
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
soranjh
approved these changes
Jun 16, 2023
obliviateandsurrender
approved these changes
Jun 16, 2023
timmysilv
added
the
merge-ready ✔️
|
[sc-38623] |
frederikwilde
pushed a commit
that referenced
this pull request
Jul 5, 2023
* save changes to tapering * add tapering update + tests * more testing * lint and tests * more tests * Apply suggestions from code review Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com> * added more tests * fix bug * lint * lint * lint * lint + codecov * more tests * Added test and warning message for coverage * Update pennylane/ops/functions/generator.py Co-authored-by: Utkarsh <utkarshazad98@gmail.com> * lint * lint and codefactor * lint + changelog * fix tests + lint * code review --------- Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com> Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.